lkml.org 
[lkml]   [2018]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] remoteproc: qcom: q6v5: shore up resource probe handling
Hi,

On Tue, Oct 9, 2018 at 3:33 PM Brian Norris <briannorris@chromium.org> wrote:
> + if (q6v5->wdog_irq < 0) {
> + if (q6v5->wdog_irq != -EPROBE_DEFER)
> + dev_err(&pdev->dev,
> + "failed to retrieve wdog IRQ: %d\n",
> + q6v5->wdog_irq);
> + return q6v5->wdog_irq;
> + }

optional: Since there's the same pattern 5 times here, I wonder if we
should abstract it out to a helper function that would print the
error?

...in the ideal case it would be somewhere that all Linux drivers
could use since this is a super common pattern, but that might be a
bit too much yak shaving...


> @@ -237,8 +260,13 @@ int qcom_q6v5_init(struct qcom_q6v5 *q6v5, struct platform_device *pdev,
> disable_irq(q6v5->handover_irq);
>
> q6v5->stop_irq = platform_get_irq_byname(pdev, "stop-ack");
> - if (q6v5->stop_irq == -EPROBE_DEFER)
> - return -EPROBE_DEFER;
> + if (q6v5->stop_irq < 0) {
> + if (q6v5->stop_irq != -EPROBE_DEFER)
> + dev_err(&pdev->dev,
> + "failed to retrieve stop IRQ: %d\n",
> + q6v5->stop_irq);
> + return q6v5->stop_irq;

Nitty nit that it's the "stop-ack" IRQ, not the "stop" IRQ. The error
message below this one calls it stop-ack too so it would be ideal to
keep it consistent between the two error messages.

Reviewed-by: Douglas Anderson <dianders@chromium.org>

\
 
 \ /
  Last update: 2018-10-10 01:35    [W:0.170 / U:0.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site