lkml.org 
[lkml]   [2018]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tpm: fix unused-value issues in tpm_try_transmit
On Wed, Oct 10, 2018 at 03:38:17PM +0200, Gustavo A. R. Silva wrote:
> Currently, there are some values assigned to variable *rc*, which
> are never actually used in any computation, because such variable
> is updated at line 550, before they can be used:
>
> 549out:
> 550 rc = tpm_go_idle(chip, flags);
> 551 if (rc)
> 552 goto out;
>
> Fix this by removing such assignments.

Should this be done by not quashing rc during the error unwind rather
than dropping the errors?

Jason

\
 
 \ /
  Last update: 2018-10-10 16:07    [W:0.091 / U:9.768 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site