lkml.org 
[lkml]   [2018]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 2/3] eeprom: at25: Use spi_message_init_with_transfers() instead of open coding
Date
Reduce code duplication in at25_ee_read() by using the
spi_message_init_with_transfers() helper.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/misc/eeprom/at25.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/misc/eeprom/at25.c b/drivers/misc/eeprom/at25.c
index 7707d3fb49b526d9..5c8dc7ad391435f7 100644
--- a/drivers/misc/eeprom/at25.c
+++ b/drivers/misc/eeprom/at25.c
@@ -103,16 +103,15 @@ static int at25_ee_read(void *priv, unsigned int offset,
*cp++ = offset >> 0;
}

- spi_message_init(&m);
memset(t, 0, sizeof(t));

t[0].tx_buf = command;
t[0].len = at25->addrlen + 1;
- spi_message_add_tail(&t[0], &m);

t[1].rx_buf = buf;
t[1].len = count;
- spi_message_add_tail(&t[1], &m);
+
+ spi_message_init_with_transfers(&m, t, ARRAY_SIZE(t));

mutex_lock(&at25->lock);

--
2.17.1
\
 
 \ /
  Last update: 2018-10-10 15:44    [W:0.107 / U:0.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site