lkml.org 
[lkml]   [2018]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH net-next 2/2] net: phy: mscc: fix memory leak in vsc8574_config_pre_init
From
Date
Hey Quentin,

On 10/10/18 8:49 AM, Quentin Schulz wrote:

>>
>> out:
>> phy_base_write(phydev, MSCC_EXT_PAGE_ACCESS, MSCC_PHY_PAGE_STANDARD);
>> -
>> +release_fw:
>> release_firmware(fw);
>
> You can reuse the out goto label instead, I would like all functions in
> the driver to exit with the PHY set to access the standard page.
>

Oh okay. I've got it.

I'll send v2 shortly.

Thanks for the feedback.
--
Gustavo

\
 
 \ /
  Last update: 2018-10-10 10:29    [W:0.047 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site