Messages in this thread | | | Subject | Re: [PATCH net-next 2/2] net: phy: mscc: fix memory leak in vsc8574_config_pre_init | From | "Gustavo A. R. Silva" <> | Date | Wed, 10 Oct 2018 10:27:20 +0200 |
| |
Hey Quentin,
On 10/10/18 8:49 AM, Quentin Schulz wrote:
>> >> out: >> phy_base_write(phydev, MSCC_EXT_PAGE_ACCESS, MSCC_PHY_PAGE_STANDARD); >> - >> +release_fw: >> release_firmware(fw); > > You can reuse the out goto label instead, I would like all functions in > the driver to exit with the PHY set to access the standard page. >
Oh okay. I've got it.
I'll send v2 shortly.
Thanks for the feedback. -- Gustavo
| |