Messages in this thread | | | Date | Tue, 9 Oct 2018 22:43:06 -0700 | From | Benson Leung <> | Subject | Re: [PATCH] platform/chrome: chromeos_tbmc - Remove unneeded const |
| |
Hi Nathan,
On Mon, Oct 08, 2018 at 03:20:41PM -0700, Nathan Chancellor wrote: > Clang warns: > > drivers/platform/chrome/chromeos_tbmc.c:102:14: warning: duplicate > 'const' declaration specifier [-Wduplicate-decl-specifier] > static const SIMPLE_DEV_PM_OPS(chromeos_tbmc_pm_ops, NULL, > ^ > ./include/linux/pm.h:365:56: note: expanded from macro > 'SIMPLE_DEV_PM_OPS' > #define SIMPLE_DEV_PM_OPS(name, suspend_fn, resume_fn) \ > ^ > 1 warning generated. > > SIMPLE_DEV_PM_OPS is already declared as const, this one is unnecessary > so remove it. > > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Applied for 4.20. Thank you.
Benson
> --- > drivers/platform/chrome/chromeos_tbmc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/chrome/chromeos_tbmc.c b/drivers/platform/chrome/chromeos_tbmc.c > index 1e81f8144c0d..ce259ec9f990 100644 > --- a/drivers/platform/chrome/chromeos_tbmc.c > +++ b/drivers/platform/chrome/chromeos_tbmc.c > @@ -99,7 +99,7 @@ static const struct acpi_device_id chromeos_tbmc_acpi_device_ids[] = { > }; > MODULE_DEVICE_TABLE(acpi, chromeos_tbmc_acpi_device_ids); > > -static const SIMPLE_DEV_PM_OPS(chromeos_tbmc_pm_ops, NULL, > +static SIMPLE_DEV_PM_OPS(chromeos_tbmc_pm_ops, NULL, > chromeos_tbmc_resume); > > static struct acpi_driver chromeos_tbmc_driver = { > -- > 2.19.0 >
-- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. bleung@google.com Chromium OS Project bleung@chromium.org [unhandled content-type:application/pgp-signature] | |