Messages in this thread | | | Date | Mon, 1 Oct 2018 10:52:12 +0200 | From | Uwe Kleine-König <> | Subject | Re: [PATCH] tty:serial:imx: use spin_lock instead of spin_lock_irqsave in isr |
| |
Hello,
On Mon, Aug 27, 2018 at 07:49:04AM -0700, jun qian wrote: > Before the program enters the uart ISR, the local interrupt has been > disabled by the system, so it's not appropriate to use spin_lock_irqsave > interface in the ISR.
"not appropriate" is a bit strong. It's not as optimal as it could be though, yes.
The change is fine,
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |
| |