Messages in this thread | | | Subject | Re: [PATCH 5/6] rpmsg: Introduce rpmsg_get_rproc_name | From | Chris Lew <> | Date | Tue, 9 Jan 2018 11:08:52 -0800 |
| |
On 12/19/2017 9:52 AM, Bjorn Andersson wrote: > On Mon 18 Dec 14:02 PST 2017, Chris Lew wrote: > >> Add support for client's to query the edge name their channel is >> registered for. This is useful for clients who share the same channel >> identifier across different remote procs. >> > > I presume this will result in a strcmp in some client driver? > > When we're registering the rpmsg device, as part of handling of an > arriving "open request", we do look for an of_node with matching > qcom,glink-channels and if one is found we point the dev->of_node of the > new device to this node. > > So I would suggest that you, in your client driver, use this to decide > which instance you're on; regardless if you're using compatible based > driver matching. > > Does this work for you? > > Regards, > Bjorn >
Yea I think this works for us, we can drop this patch.
Just to confirm my understanding, clients can use rpdev->dev.of_node to get the parent of_node and from there get the label field? Also to ensure of_node is set, client's need to add their channel to the dt with qcom,glink-channels.
-- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
| |