Messages in this thread | | | Date | Mon, 8 Jan 2018 18:03:39 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH 2/3] drivers/fbtft: Remove unnecessary braces from if/else |
| |
On Mon, Jan 08, 2018 at 11:06:37AM +0100, Luis Gerhorst wrote: > The Linux kernel coding style states that braces should only be used > when necessary. > > This fixes the checkpatch warning > > WARNING: line over 80 characters > + } else if (display->regwidth == 8 && display->buswidth == 9 && par->spi) { > > introduced by patch #1. >
Don't introduce warnings and then fix them in later patches.
Anyway there is another unwritten rule that multi-line indents get curly braces. Probably it should be:
} else if (display->regwidth == 8 && display->buswidth == 9 && par->spi) {
regards, dan carpenter
| |