Messages in this thread | | | Date | Mon, 8 Jan 2018 11:38:59 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH v7 3/6] perf util: Create function to parse time percent |
| |
Em Mon, Jan 08, 2018 at 11:31:49AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Fri, Dec 08, 2017 at 09:13:43PM +0800, Jin Yao escreveu: > > Current perf report/script/... have a --time option to limit the time > > range of output. But right now it only supports absolute time. > > > > For easy using, now it can support a percent of time usage. > > > > For example: > > > > 1. Select the second 10% time slice > > perf report --time 10%/2 > > After applying this patch I'm not being able to get any of these > examples to work: > > [root@jouet home]# perf report --header | grep "time of" > # time of first sample : 22947.909226 > # time of last sample : 22948.910704 > [root@jouet home]# > > Then, when I try the first example: > > [root@jouet home]# perf report --stdio --time 1%-20% > Invalid time string > # To display the perf.data header info, please use --header/--header-only options. > # > [root@jouet home]# > > What am I doing wrong?
Oh well, the way you worded this cset it looked like after applying it I would be able to use percents, etc, which is not the case, I'll probably need to apply the next patches to _then_ this work as advertised in this cset comment.
Please try to make it clear in the commit messages these details, to ease reviewing.
- Arnaldo
| |