Messages in this thread | | | Subject | Re: [PATCH 1/3] GenWQE: Delete an error message for a failed memory allocation in genwqe_user_vmap() | From | SF Markus Elfring <> | Date | Mon, 8 Jan 2018 14:24:41 +0100 |
| |
>> @@ -593,7 +593,6 @@ int genwqe_user_vmap(struct genwqe_dev *cd, struct >> dma_mapping *m, void *uaddr, >> sizeof(struct page *) + sizeof(dma_addr_t), >> GFP_KERNEL); >> if (!m->page_list) { >> - dev_err(&pci_dev->dev, "err: alloc page_list failed\n"); > > Are there different printouts which cover this?
Is this error message redundant?
> I mean the debug printout is not appearing all the time, > it must be enabled, if I remember correctly.
Would you like to clarify corresponding configuration possibilities any more?
> So why do you suggest to remove it?
Can the Linux allocation failure report be sufficient for this use case already?
Regards, Markus
| |