Messages in this thread | | | Subject | Re: b43: Replace mdelay with msleep in b43_radio_2057_init_post | From | Jia-Ju Bai <> | Date | Tue, 9 Jan 2018 09:36:38 +0800 |
| |
On 2018/1/9 0:31, Larry Finger wrote: > On 01/08/2018 10:21 AM, Kalle Valo wrote: >> Jia-Ju Bai <baijiaju1990@gmail.com> wrote: >> >>> b43_radio_2057_init_post is not called in an interrupt handler >>> nor holding a spinlock. >>> The function mdelay in it can be replaced with msleep, to reduce >>> busy wait. >>> >>> Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com> >> >> You submitted an identical patch a week earlier: >> >> https://patchwork.kernel.org/patch/10137671/ >> >> How is this different? Also always add version number to the patch so >> that the >> maintainers can follow the changes easily: >> >> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#patch_version_missing >> >> >> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#changelog_missing >> > > I had negative comments on one of those due to the possibility of > msleep(2) extending as long as 20 msec. Until the author, or someone > else, can test that this is OK, then the mdelay(2) can only be > replaced with usleep_range(2000, 3000). > > NACK for both. > > Larry >
Sorry for my mistake. I have sent a patch v2 using usleep_range(2000, 3000), and you can have a look :)
Thanks, Jia-Ju Bai
| |