Messages in this thread | | | Date | Sat, 6 Jan 2018 12:50:20 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH] arch/x86/boot: sizeof macro |
| |
* Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> On Fri, Dec 29, 2017 at 9:46 PM, Ingo Molnar <mingo@kernel.org> wrote: > > * Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > > >> > - ireg.cx = sizeof buf; > >> > + ireg.cx = sizeof(buf); > >> > >> sizeof is operator, not a function. > >> So, what are you trying to achieve? > > > > That's true, but in the kernel coding style we use it as a function: > > Yeah, the question is do we need to change all those 177 occurrences at all? > Or perhaps it might be an opportunity during some other changes to > certain users...
We probably don't want to change then, and my point was that 99.8% of the current usage is as a 'function':
triton:~/tip> git grep 'sizeof(' | wc -l 116570
triton:~/tip> git grep 'sizeof [:alnum:]' | wc -l 177
i.e. your patch moves it in the exact wrong direction.
Thanks,
Ingo
| |