lkml.org 
[lkml]   [2018]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] pinctrl: imx6ul: add IOMUXC SNVS pinctrl driver for i.MX 6ULL
On 2018-01-03 09:09, Linus Walleij wrote:
> On Tue, Jan 2, 2018 at 5:40 PM, Stefan Agner <stefan@agner.ch> wrote:
>
>> From: Bai Ping <ping.bai@nxp.com>
>>
>> On i.MX 6ULL, the BOOT_MODEx and TAMPERx pin MUX and CTRL registers
>> are available in a separate IOMUXC_SNVS module. Add support for the
>> IOMUXC_SNVS module to the i.MX 6UL pinctrl driver.
>>
>> Signed-off-by: Bai Ping <ping.bai@nxp.com>
>> Signed-off-by: Stefan Agner <stefan@agner.ch>
>
> So 6 unsigned long 32 bit is succeeded by 6 unsigned long long, 64 bit?
>
> Someone is having fun naming these platforms I see.

Hehe, yeah definitely. At least they use proper type suffixes ;-)

>
>> Required properties:
>> -- compatible: "fsl,imx6ul-iomuxc"
>> +- compatible: "fsl,imx6ul-iomuxc" for main IOMUX controller or
>> + "fsl,imx6ull-iomuxc-snvs" for i.MX 6ULL's SNVS IOMUX controller.
>
> Pretty uncontroversial change but still nice to give the DT people a chance
> to ACK it.
>
>> static int imx6ul_pinctrl_probe(struct platform_device *pdev)
>> {
>> - return imx_pinctrl_probe(pdev, &imx6ul_pinctrl_info);
>> + const struct of_device_id *match;
>> + struct imx_pinctrl_soc_info *pinctrl_info;
>> +
>> + match = of_match_device(imx6ul_pinctrl_of_match, &pdev->dev);
>> +
>> + if (!match)
>> + return -ENODEV;
>> +
>> + pinctrl_info = (struct imx_pinctrl_soc_info *) match->data;
>
> 1. Do not use a cast on void * pointers.
>
> 2. Use this function:
> extern const void *of_device_get_match_data(const struct device *dev);
>
> From <linux/of_device.h>

Ok. We use the same code in pinmux-imx7d.c, will send a patch to
simplify that too.

--
Stefan

\
 
 \ /
  Last update: 2018-01-06 12:15    [W:0.059 / U:12.924 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site