lkml.org 
[lkml]   [2018]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[GIT PULL 22/25] lightnvm: pblk: free write buffer on init failure
    Date
    From: Javier González <javier@cnexlabs.com>

    Refactor the way we free the write buffer to ensure that all entries get
    freed in case of an error on the init sequence.

    Signed-off-by: Javier González <javier@cnexlabs.com>
    Signed-off-by: Matias Bjørling <m@bjorling.me>
    ---
    drivers/lightnvm/pblk-init.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/lightnvm/pblk-init.c b/drivers/lightnvm/pblk-init.c
    index 7e11926..8c40bc3 100644
    --- a/drivers/lightnvm/pblk-init.c
    +++ b/drivers/lightnvm/pblk-init.c
    @@ -355,6 +355,8 @@ static void pblk_core_free(struct pblk *pblk)
    mempool_destroy(pblk->e_rq_pool);
    mempool_destroy(pblk->w_rq_pool);

    + pblk_rwb_free(pblk);
    +
    pblk_free_global_caches(pblk);
    }

    @@ -931,7 +933,6 @@ static void pblk_tear_down(struct pblk *pblk)
    pblk_pipeline_stop(pblk);
    pblk_writer_stop(pblk);
    pblk_rb_sync_l2p(&pblk->rwb);
    - pblk_rwb_free(pblk);
    pblk_rl_free(&pblk->rl);

    pr_debug("pblk: consistent tear down\n");
    --
    2.9.3
    \
     
     \ /
      Last update: 2018-01-05 14:18    [W:4.192 / U:0.140 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site