Messages in this thread | | | Subject | Re: [PATCH] dmaengine: qcom_hidma: simplify DT resource parsing | From | Sinan Kaya <> | Date | Thu, 4 Jan 2018 18:34:34 -0500 |
| |
On 1/4/2018 5:45 PM, Rob Herring wrote: > The hidma driver open codes populating address and IRQ resources from DT. > We have standard functions of_address_to_resource and of_irq_to_resource > for this, so use them instead. > > The DT binding states each child should have 2 addresses and 1 IRQ, so we > can simplify the logic and do a fixed size resource allocation. Using the > standard of_address_to_resource will also do any address translation which > was missing. > > Cc: Andy Gross <andy.gross@linaro.org> > Cc: David Brown <david.brown@linaro.org> > Cc: Dan Williams <dan.j.williams@intel.com> > Cc: Vinod Koul <vinod.koul@intel.com> > Cc: linux-arm-msm@vger.kernel.org > Cc: linux-soc@vger.kernel.org > Cc: dmaengine@vger.kernel.org > Signed-off-by: Rob Herring <robh@kernel.org> > --- > drivers/dma/qcom/hidma_mgmt.c | 61 +++++++++++-------------------------------- > 1 file changed, 15 insertions(+), 46 deletions(-)
Thanks, this certainly looks cleaner. Mine was mostly copy/paste from other examples.
Reviewed-by: Sinan Kaya <okaya@codeaurora.org>
-- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
| |