Messages in this thread | | | Date | Thu, 4 Jan 2018 10:06:01 -0600 | From | Josh Poimboeuf <> | Subject | Re: [PATCH v2 11/12] retpoline/objtool: Disable some objtool warnings |
| |
On Thu, Jan 04, 2018 at 07:59:14AM -0800, Andi Kleen wrote: > > NAK. We can't blindly disable objtool warnings, that will break > > livepatch and the ORC unwinder. If you share a .o file (or the GCC > > code) I can look at adding retpoline support. > > I don't think we can wait for that. We can disable livepatch and the > unwinder for now. They are not essential. Frame pointers should work > well enough for unwinding
If you want to make this feature conflict with livepatch and ORC, silencing objtool warnings is not the way to do it.
> and afaik nobody can use livepatch in mainline anyways.
Why not? The patch creation tooling is still out-of-tree, but livepatch itself is fully supported in mainline.
-- Josh
| |