Messages in this thread | | | Subject | Re: ethernet: mlx4: Delete an error message for a failed memory allocation in five functions | From | Tariq Toukan <> | Date | Thu, 4 Jan 2018 11:24:56 +0200 |
| |
On 03/01/2018 4:22 PM, SF Markus Elfring wrote: >> I don't really accept this claim... >> Short informative strings worth the tiny space they consume. > > There can be different opinions for their usefulness. > > >> In addition, some out-of-memory errors are recoverable, even though their backtrace is also printed. > > How do you think about to suppress the backtrace generation for them? > > OK, makes sense.
>> For example, in function mlx4_en_create_cq (appears in patch) we have a first allocation attempt (kzalloc_node) > > Would it be helpful to pass the option “__GFP_NOWARN” there? > >
I'll prepare a patch to use it. Will ack this patch for now.
>> and a fallback (kzalloc). I'd prefer to state a clear error message only when both have failed, >> because otherwise the user might be confused whether the backtrace should indicate a malfunctioning interface, or not. > > Can the distinction become easier by any other means? > > Regards, > Markus > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
| |