Messages in this thread | | | From | Andy Shevchenko <> | Date | Wed, 31 Jan 2018 14:58:57 +0200 | Subject | Re: [PATCH] wireless: zd1211rw: remove redundant assignment of pointer 'q' |
| |
On Tue, Jan 30, 2018 at 8:25 PM, Colin King <colin.king@canonical.com> wrote: > From: Colin Ian King <colin.king@canonical.com> > > Pointer q is initialized and then almost immediately afterwards being > re-assigned the same value. Remove the second redundant assignment. >
Don't you see strange that in the same context of the patch two users of q are present?
How did you test this?
> Cleans up clang warning: > drivers/net/wireless/zydas/zd1211rw/zd_mac.c:503:23: warning: Value > stored to 'q' during its initialization is never read
> - q = &mac->ack_wait_queue; > spin_lock_irqsave(&q->lock, flags); > > skb_queue_walk(q, skb) {
-- With Best Regards, Andy Shevchenko
| |