Messages in this thread | | | Date | Wed, 31 Jan 2018 07:17:31 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH 4/4] objtool: Don't print '.tmp_' prefix for .o files |
| |
* Josh Poimboeuf <jpoimboe@redhat.com> wrote:
> On Tue, Jan 30, 2018 at 10:58:31AM +0100, Peter Zijlstra wrote: > > On Mon, Jan 29, 2018 at 10:00:42PM -0600, Josh Poimboeuf wrote: > > > With the following commit: > > > > > > 2a0098d70640 ("objtool: Fix seg fault with gold linker") > > > > > > ... objtool warnings started showing the modversions '.tmp_' prefix in > > > the .o file name, like: > > > > > > arch/x86/mm/.tmp_mem_encrypt_boot.o: warning: objtool: sme_encrypt_execute()+0x48: indirect call found in RETPOLINE build > > > > > > The prefix is confusing. Remove it from the printed 'objname' variable. > > > > This patch actually tripped me up today. Turns out I have both: > > > > build/kernel/sched/core.o > > build/kernel/sched/.tmp_core.o > > > > and ended up staring at the wrong file and going WTF because the offsets > > didn't match. > > > > I much prefer the actual real filename printed. Yes the .tmp_ crud is > > weird, but at least its the real file. > > Good point, sorry for tripping you up there. I see it's been removed > from -tip now. [...]
Yeah, and we had to rebase to a later kernel anyway so it was easy to remove it for now.
Thanks,
Ingo
| |