lkml.org 
[lkml]   [2018]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 26/43] drm/bridge: analogix_dp: Don't use ANALOGIX_DP_PLL_CTL to control pll
    Date
    From: zain wang <wzz@rock-chips.com>

    There is no register named ANALOGIX_DP_PLL_CTL in Rockchip edp phy reg
    list. We should use BIT_4 in ANALOGIX_DP_PD to control the pll power
    instead of ANALOGIX_DP_PLL_CTL.

    Cc: Douglas Anderson <dianders@chromium.org>
    Signed-off-by: zain wang <wzz@rock-chips.com>
    Signed-off-by: Sean Paul <seanpaul@chromium.org>
    Signed-off-by: Thierry Escande <thierry.escande@collabora.com>
    Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
    ---
    drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c | 20 ++++++++++++--------
    1 file changed, 12 insertions(+), 8 deletions(-)

    diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c
    index 7b7fd227e1f9..02ab1aaa9993 100644
    --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c
    +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c
    @@ -230,16 +230,20 @@ enum pll_status analogix_dp_get_pll_lock_status(struct analogix_dp_device *dp)
    void analogix_dp_set_pll_power_down(struct analogix_dp_device *dp, bool enable)
    {
    u32 reg;
    + u32 mask = DP_PLL_PD;
    + u32 pd_addr = ANALOGIX_DP_PLL_CTL;

    - if (enable) {
    - reg = readl(dp->reg_base + ANALOGIX_DP_PLL_CTL);
    - reg |= DP_PLL_PD;
    - writel(reg, dp->reg_base + ANALOGIX_DP_PLL_CTL);
    - } else {
    - reg = readl(dp->reg_base + ANALOGIX_DP_PLL_CTL);
    - reg &= ~DP_PLL_PD;
    - writel(reg, dp->reg_base + ANALOGIX_DP_PLL_CTL);
    + if (dp->plat_data && is_rockchip(dp->plat_data->dev_type)) {
    + pd_addr = ANALOGIX_DP_PD;
    + mask = RK_PLL_PD;
    }
    +
    + reg = readl(dp->reg_base + pd_addr);
    + if (enable)
    + reg |= mask;
    + else
    + reg &= ~mask;
    + writel(reg, dp->reg_base + pd_addr);
    }

    void analogix_dp_set_analog_power_down(struct analogix_dp_device *dp,
    --
    2.14.1
    \
     
     \ /
      Last update: 2018-01-30 21:35    [W:2.167 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site