Messages in this thread | | | Date | Tue, 30 Jan 2018 05:13:25 -0500 | From | Steven Rostedt <> | Subject | Re: [PATCH] ftrace: use helper function clear_ftrace_function |
| |
On Tue, 30 Jan 2018 08:46:01 +0800 Yisheng Xie <xieyisheng1@huawei.com> wrote:
> We have helper function clear_ftrace_function(), use it instead of hard > code. And this should not have any functional change. > > Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com> > --- > kernel/trace/ftrace.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c > index 554b517..ba78e03 100644 > --- a/kernel/trace/ftrace.c > +++ b/kernel/trace/ftrace.c > @@ -6779,7 +6779,7 @@ int unregister_ftrace_function(struct ftrace_ops *ops) > > } else { > /* stopping ftrace calls (just send to ftrace_stub) */ > - ftrace_trace_function = ftrace_stub; > + clear_ftrace_function(); > > ftrace_shutdown_sysctl(); > }
Honestly, I rather nuke that function and clear_ftrace_function_probe() along with it. They are not used outside of ftrace.c and they don't actually help.
-- Steve
| |