lkml.org 
[lkml]   [2018]   [Jan]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH -next] irqchip/ompic: fix return value check in ompic_of_init()
Date
On Wed, Jan 03, 2018 10:41 PM, Stafford Horne wrote:
> On Tue, Jan 02, 2018 at 11:47:19AM +0000, Wei Yongjun wrote:
> > In case of error, the function ioremap() returns NULL pointer not
> > ERR_PTR(). The IS_ERR() test in the return value check should be
> > replaced with NULL test.
>
> Thanks, I am not sure why I was using the *ERR*() macros. 2 questions:
>
> - How did you notice this?

This is detected by Coccinelle semantic patch.

> - Should I pull this in through my tree or do you have another route? i.e.
> Marc?

Feel free to pull this through your tree.


\
 
 \ /
  Last update: 2018-01-04 04:58    [W:0.049 / U:26.080 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site