lkml.org 
[lkml]   [2018]   [Jan]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RESEND PATCH v2 14/15] ASoC: qcom: apq8096: Add db820c machine driver
On Wed 03 Jan 08:27 PST 2018, Srinivas Kandagatla wrote:

> Thanks for the review comments.
>
>
> On 03/01/18 00:16, Bjorn Andersson wrote:
> > On Thu 14 Dec 09:34 PST 2017, srinivas.kandagatla@linaro.org wrote:
> >
> > > From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> > >
> > > uThis patch adds support to DB820c machine driver.
> >
> > Drop 'u' and expand the message to claim that this is the machine driver
> > for 8996, used by the db820c.
> >
> > [..]
> > > +static struct snd_soc_dai_link msm8996_dai_links[] = {
> >
> > Are there any differences between the DAI links of apq8096 and msm8996?
> >
> This driver is more of board specific,
> Am not 100% sure about msm8996, on apq8096 in particularly on db820c we got
> hdmi and analog audio connected via slimbus and also I2S on lowspeed
> connector.
>

Can this be kept platform specific and the board specific routing put in
DT?

I don't think we want to have a machine-driver for each board. Right now
you have 25 dtbs in mainline, that's going to be a lot of machine
drivers...

Regards,
Bjorn

\
 
 \ /
  Last update: 2018-01-03 21:05    [W:0.066 / U:3.288 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site