lkml.org 
[lkml]   [2018]   [Jan]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH net-next 1/6] phy: add 2.5G SGMII mode to the phy_mode enum
    > > >>> diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h
    > > >>> index 4f8423a948d5..70459a28f3a1 100644
    > > >>> --- a/include/linux/phy/phy.h
    > > >>> +++ b/include/linux/phy/phy.h
    > > >>> @@ -28,6 +28,7 @@ enum phy_mode {
    > > >>> PHY_MODE_USB_DEVICE,
    > > >>> PHY_MODE_USB_OTG,
    > > >>> PHY_MODE_SGMII,
    > > >>> + PHY_MODE_SGMII_2_5G,
    > > >>> PHY_MODE_10GKR,
    > > >>> PHY_MODE_UFS_HS_A,
    > > >>> PHY_MODE_UFS_HS_B,
    > > >>
    > > >> There was a discussion maybe last month about adding 2.5G SGMII. I
    > > >> would prefer 2500SGMII. Putting the number first makes it uniform with
    > > >> the other defines, 1000BASEX, 25000BASEX, 10GKR.
    > > >
    > > > Good to know. I wasn't completely sure how to name this mode properly,
    > > > but I'm fine with PHY_MODE_2500SGMII. I'll update the patches and send a
    > > > v2 (without the dt part).
    > >
    > > And since you are respinning, please make sure you update phy_modes() in
    > > the same header file as well as
    > > Documentation/devicetree/bindings/net/ethernet.txt with the newly added
    > > PHY interface mode.
    >
    > Actually it's a generic PHY mode I'm adding, not a network PHY mode.
    > There's no phy_modes() function for generic PHYs (and this 2500BaseX
    > mode already is supported in the network PHY modes).

    Hi Antoine

    Don't you need it in both include/linux/phy/phy.h and
    include/linux/phy.h?

    Andrew

    \
     
     \ /
      Last update: 2018-01-03 16:09    [W:3.696 / U:0.316 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site