lkml.org 
[lkml]   [2018]   [Jan]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH V4 06/26] edd: deprecate pci_get_bus_and_slot()
From
Date
On 12/19/2017 12:37 AM, Sinan Kaya wrote:
> pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as
> where a PCI device is present. This restricts the device drivers to be
> reused for other domain numbers.
>
> Getting ready to remove pci_get_bus_and_slot() function in favor of
> pci_get_domain_bus_and_slot().
>
> Domain number is not available in struct edd_info. Hard-coding the domain
> number as 0.
>
> Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
> ---
> drivers/firmware/edd.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/firmware/edd.c b/drivers/firmware/edd.c
> index e229576..60a8f13 100644
> --- a/drivers/firmware/edd.c
> +++ b/drivers/firmware/edd.c
> @@ -669,10 +669,10 @@ static void edd_release(struct kobject * kobj)
> struct edd_info *info = edd_dev_get_info(edev);
>
> if (edd_dev_is_type(edev, "PCI") || edd_dev_is_type(edev, "XPRS")) {
> - return pci_get_bus_and_slot(info->params.interface_path.pci.bus,
> - PCI_DEVFN(info->params.interface_path.pci.slot,
> - info->params.interface_path.pci.
> - function));
> + return pci_get_domain_bus_and_slot(0,
> + info->params.interface_path.pci.bus,
> + PCI_DEVFN(info->params.interface_path.pci.slot,
> + info->params.interface_path.pci.function));
> }
> return NULL;
> }
>

Any feedback here? most of the remaining patches have the ACK except these.


--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.

\
 
 \ /
  Last update: 2018-01-03 13:49    [W:0.039 / U:21.432 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site