[lkml]   [2018]   [Jan]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] nvme: check ctrl.tagset before start ns scan
Hi Jianchao,

> ctrl.tagset maybe NULL due to failure of io queue setup or blk-mq
> tagset allocation in nvme_reset_work. Then panic would come up.
> To fix this, just add ctrl.tagset check in nvme_scan_work.

This came up before (and forgotten...) I think we should not
have state indicators other than ctrl->state.

How about instead we add a new state NVME_CTRL_ADMIN_LIVE when we have
no I/O queues.

 \ /
  Last update: 2018-01-03 10:38    [W:0.057 / U:0.400 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site