Messages in this thread | | | Subject | Re: [PATCH] ACPI: Parse entire table as a term_list for Dell XPS 9570 and Precision M5530 | From | Kai Heng Feng <> | Date | Tue, 30 Jan 2018 10:46:53 +0800 |
| |
> On 29 Jan 2018, at 8:56 PM, Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > > On Mon, Jan 29, 2018 at 8:10 AM, Kai-Heng Feng > <kai.heng.feng@canonical.com> wrote: >> The i2c touchpad on Dell XPS 9570 and Precision M5530 doesn't work out >> of box. >> >> The touchpad relies on its _INI method to update its _HID value from >> XXXX0000 to SYNA2393. >> Also, the _STA relies on value of I2CN to report correct status. >> >> Set acpi_gbl_parse_table_as_term_list so the value of I2CN can be >> correctly set up, and _INI can get run. The ACPI table in this machine >> is designed to get parsed this way. > >> +#ifdef CONFIG_X86 > > Why do you need separate #ifdef? > >> +static const struct dmi_system_id gbl_term_list_dmi_table[] __initconst = { > > I think you can just add new items to the existing table, while renaming it like > > dsdt_dmi_table -> acpi_quirks_dmi_table
Thanks for your suggestion, this is a better approach. I’ll address them in V2 patch.
Kai-Heng
> > -- > With Best Regards, > Andy Shevchenko
| |