lkml.org 
[lkml]   [2018]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL for 3.18 25/25] hippi: Fix a Fix a possible sleep-in-atomic bug in rr_close
    Date
    From: Jia-Ju Bai <baijiaju1990@163.com>

    [ Upstream commit 6e266610eb6553cfb7e7eb5d11914bd01509c406 ]

    The driver may sleep under a spinlock.
    The function call path is:
    rr_close (acquire the spinlock)
    free_irq --> may sleep

    To fix it, free_irq is moved to the place without holding the spinlock.

    This bug is found by my static analysis tool(DSAC) and checked by my code review.

    Signed-off-by: Jia-Ju Bai <baijiaju1990@163.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    ---
    drivers/net/hippi/rrunner.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/hippi/rrunner.c b/drivers/net/hippi/rrunner.c
    index 95c0b45a68fb..313e006f74fe 100644
    --- a/drivers/net/hippi/rrunner.c
    +++ b/drivers/net/hippi/rrunner.c
    @@ -1381,8 +1381,8 @@ static int rr_close(struct net_device *dev)
    rrpriv->info_dma);
    rrpriv->info = NULL;

    - free_irq(pdev->irq, dev);
    spin_unlock_irqrestore(&rrpriv->lock, flags);
    + free_irq(pdev->irq, dev);

    return 0;
    }
    --
    2.11.0
    \
     
     \ /
      Last update: 2018-01-28 23:34    [W:3.113 / U:0.560 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site