lkml.org 
[lkml]   [2018]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] x86/entry/64: Remove the SYSCALL64 fast path

* Andy Lutomirski <luto@kernel.org> wrote:

> The SYCALLL64 fast path was a nice, if small, optimization back in
> the good old days when syscalls were actually reasonably fast. Now
> we have PTI to slow everything down, and indirect branches are
> verboten, making everything messier. The retpoline code in the fast
> path was particularly nasty.
>
> Just get rid of the fast path. The slow path is barely slower.
>
> Signed-off-by: Andy Lutomirski <luto@kernel.org>
> ---
>
> This isn't quite identical to Linus' patch. I cleaned up the
> SYSCALL64 entry code to use all pushes rather than pushing all but 6
> regs and moving the rest.

Hm, could we please have this in two parts please, out of general paranoia?

One patch doing the easy fast path removal, the other doing the mov/push
conversion?

Bisectability, reviewability and all that.

Exact same patch result.

Thanks,

Ingo

\
 
 \ /
  Last update: 2018-01-28 20:01    [W:0.129 / U:0.944 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site