lkml.org 
[lkml]   [2018]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 11/15] gen_init_cpio: add newcx format
From
Date
On 01/24/2018 09:27 PM, Taras Kondratiuk wrote:
> diff --git a/usr/gen_init_cpio.c b/usr/gen_init_cpio.c
> index 7a2a6d85345d..78a47a5bdcb1 100644
> --- a/usr/gen_init_cpio.c
> +++ b/usr/gen_init_cpio.c
> @@ -10,6 +10,7 @@
> #include <errno.h>
> #include <ctype.h>
> #include <limits.h>
> +#include <assert.h>

You're adding an assert? Really?

> fputs(s, stdout);
> - offset += 110;
> + assert((offset & 3) == 0);
> + offset += cpio_hdr_size;

Why?

Rob

\
 
 \ /
  Last update: 2018-01-26 03:41    [W:0.116 / U:0.640 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site