lkml.org 
[lkml]   [2018]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] platform/x86: dell-laptop: Add 2-in-1 devices to the DMI whitelist
On Thursday 25 January 2018 15:02:39 Darren Hart wrote:
> On Fri, Jan 26, 2018 at 01:48:57AM +0300, Alexander Abrosimov wrote:
> > SMBIOS 3.0.0 Specification introduced new Chassis Types field values for
> > 2-in-1 devices like tablets, convertibles and detachables. Dell's
> > Inspiron 2-in-1 and XPS 2-in-1 fall into this category and they have to
> > be added to the DMI whitelist, so rfkill and backlight can be controlled
> > for them as for other laptops.
> >
> > Signed-off-by: Alexander Abrosimov <alexander.n.abrosimov@gmail.com>
>
> Thanks Alexander. Looks good - just going to give Pali and +Mario a chance to
> respond before merging...

I have no comments for this. This should be confirmed by Mario or
somebody else from Dell, which DMI names are used for a new products.

> > ---
> > drivers/platform/x86/dell-laptop.c | 18 ++++++++++++++++++
> > 1 file changed, 18 insertions(+)
> >
> > diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
> > index cd4725e7e0b5..23fc94d70ea1 100644
> > --- a/drivers/platform/x86/dell-laptop.c
> > +++ b/drivers/platform/x86/dell-laptop.c
> > @@ -110,6 +110,24 @@ static const struct dmi_system_id dell_device_table[] __initconst = {
> > },
> > },
> > {
> > + .matches = {
> > + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> > + DMI_MATCH(DMI_CHASSIS_TYPE, "30"), /*Tablet*/
> > + },
> > + },
> > + {
> > + .matches = {
> > + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> > + DMI_MATCH(DMI_CHASSIS_TYPE, "31"), /*Convertible*/
> > + },
> > + },
> > + {
> > + .matches = {
> > + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> > + DMI_MATCH(DMI_CHASSIS_TYPE, "32"), /*Detachable*/
> > + },
> > + },
> > + {
> > .ident = "Dell Computer Corporation",
> > .matches = {
> > DMI_MATCH(DMI_SYS_VENDOR, "Dell Computer Corporation"),
> > --
> > 2.13.6
> >
> >
>

--
Pali Rohár
pali.rohar@gmail.com
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2018-01-26 00:06    [W:0.043 / U:1.492 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site