Messages in this thread | | | Subject | Re: [tip:x86/pti] x86/retpoline: Fill return stack buffer on vmexit | From | David Woodhouse <> | Date | Thu, 25 Jan 2018 16:03:18 +0000 |
| |
On Thu, 2018-01-25 at 16:51 +0100, Borislav Petkov wrote: > > > And the seg fault is objtool's way of telling you you need a > > ANNOTATE_NOSPEC_ALTERNATIVE above the alternative ;-) > > Except that it blew up when I did this which doesn't have ALTERNATIVE > (it's the diff I saved :-))
Yeah, ANNOTATE_NOSPEC_ALTERNATIVE just tells objtool "don't look at the alternative; you're not going to like it".
If you start putting a __fill_rsb() function out of line somewhere and only *calling* it from alternatives, then objtool is going to shit itself when it sees that function, regardless.[unhandled content-type:application/x-pkcs7-signature] | |