| Subject | Re: [PATCH v6 05/99] xarray: Add definition of struct xarray | From | Paul Bolle <> | Date | Wed, 24 Jan 2018 09:45:22 +0100 |
| |
Mathhew,
Just a minor question.
On Wed, 2018-01-17 at 12:20 -0800, Matthew Wilcox wrote: > This is a direct replacement for struct radix_tree_root. Some of the > struct members have changed name; convert those, and use a #define so > that radix_tree users continue to work without change. > > Signed-off-by: Matthew Wilcox <mawilcox@microsoft.com>
> --- a/include/linux/xarray.h > +++ b/include/linux/xarray.h > @@ -10,6 +10,8 @@ > */ > > #include <linux/bug.h> > +#include <linux/compiler.h> > +#include <linux/kconfig.h>
The top Makefile includes linux/kconfig.h globally. (See the odd USERINCLUDE variable, which is actually part of the LINUXINCLUDE variable, but split off to make things confusing.)
Why do you need to include linux/kconfig.h here?
> #include <linux/spinlock.h> > #include <linux/types.h>
Thanks,
Paul Bolle
|