Messages in this thread | | | Subject | Re: [PATCH 1/2] block: blk-tag: Replace GFP_ATOMIC with GFP_KERNEL in __blk_queue_init_tags | From | Jens Axboe <> | Date | Wed, 24 Jan 2018 20:44:26 -0700 |
| |
On 1/24/18 8:38 PM, Jia-Ju Bai wrote: > After checking all possible call chains to kmalloc here, > my tool finds that kmalloc is never called in atomic context. > Thus GFP_ATOMIC is not necessary, and it can be replaced with GFP_KERNEL. > > This is found by a static analysis tool named DCNS written by myself.
These two look OK to me, mostly. One issue is that blk_queue_init_tags() can be used to resize tags, in which case it's called with the queue lock held. Nobody is using it like that anymore, though. So I'd prefer if you did a v2 of this patch, and include a correction to that comment.
-- Jens Axboe
| |