lkml.org 
[lkml]   [2018]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT PULL] PCI fixes for v4.15
On Tue, Jan 23, 2018 at 12:49:22PM -0800, Linus Torvalds wrote:
> On Tue, Jan 23, 2018 at 11:56 AM, Bjorn Helgaas <helgaas@kernel.org> wrote:
> >
> > - fix AMD regression due to not re-enabling the big window on resume
> > (Christian König)
>
> Bjorn, I think you need to look at your email habits.
>
> I suspect you're editing your mailbox, or you're using some broken
> mailer setup, or something (using some broken "export" function?),
> because you're corrupting Christian's name all the time:
>
> > =?UTF-8?q?Christian=20K=C3=B6nig?= (1):
> > x86/PCI: Enable AMD 64-bit window on resume
>
> and I'm pretty sure git gets this right if actually fed a real mbox,
> but I suspect that you have some other workflow going on..

I'm not editing my mailbox, but I am using stgit. The "From:" header
uses encoded-word syntax for Christian's name, and I think stgit is
not decoding that when applying the patch.

When I save the patch email message from mutt (or gmail, for that
matter), I see:

From: "=?UTF-8?q?Christian=20K=C3=B6nig?=" ...

Applying that patch with "git am" results in the correct

Author: Christian König <ckoenig.leichtzumerken@gmail.com

Applying the identical patch with "stg import -M" results in

Author: =?UTF-8?q?Christian=20K=C3=B6nig?= <ckoenig.leichtzumerken@gmail.com>

Some of Christian's PCI patches came out OK (8bb705e3e79d,
276b738deb5b, cb21bc9469c4). I don't remember specifically, but I
suspect I fixed those manually.

I don't know if there's some stg configuration I could do to fix this.
I looked a little bit but haven't found anything yet.

Thanks for pointing this out. I'll try to fix this one way or another
in the future.

Bjorn

\
 
 \ /
  Last update: 2018-01-24 01:46    [W:0.496 / U:0.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site