lkml.org 
[lkml]   [2018]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] acpi, spcr: Make SPCR available to x86
From
Date


On 01/22/2018 04:49 PM, Timur Tabi wrote:
> On 01/18/2018 09:09 AM, Prarit Bhargava wrote:
>> if (acpi_disabled) {
>> - if (earlycon_init_is_deferred)
>> + if (earlycon_acpi_spcr_enable)
>
> This patch works for me, so I can ACK it, but first you might want to rename
> earlycon_acpi_spcr_enable, because these two lines don't make much sense.
>
> "If ACPI is disabled, and ACPI SCPR is enabled, then ...."
>
> If ACPI is disabled, then how can a variable called "earlycon_acpi_spcr_enable"
> be true?
>
> Would it make more sense to rename it to earlycon_spcr_enable?
>

acpi_disabled is a global runtime flag that can be set via "acpi=off" on the
command line. It does not disable the tables, only the reading and interpreting
of the data in the tables.

P.

\
 
 \ /
  Last update: 2018-01-23 13:43    [W:0.132 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site