[lkml]   [2018]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [patch v9 3/4] platform/mellanox: mlxreg-hotplug: Code cleanup
On Wed, Jan 17, 2018 at 06:21:55PM +0000, Vadim Pasternak wrote:

As I continue to pick these patches apart into their individual functional
changes, I'm finding more issues...

> Renaming field bus in structure mlxreg_hotplug_device to nr to have a name
> consistent with Linux i2c naming.
> Removing unnecessary includes.
> Removing from mlxreg_hotplug_device_create dev_err to upper layer should
> produce error on EFAULT return.

But the only caller doesn't check the return code. Where did you expect for this
error to be detected?

> Relocation mlxreg_hotplug_device_create/destroy to the beginning of the
> mlxreg-hotplug.c in order to have attribute related code at the same
> location.
> Add to structure mlxreg_hotplug_device device node handle for devices
> defined in device table tree;

The above should *really* be several changes. Start with the non-functional
preparatory changes, followed by single functional change. Also, it seems to me
adding the device node prior to enabling building on ARM would make sense??

I've broken this up, verified incremental build, and rewritten the commit
messages. I have this sitting in a local branch currently.

I need you to respond to the question above re the create call, but I'll make
the change myself.

Darren Hart
VMware Open Source Technology Center

 \ /
  Last update: 2018-01-23 04:54    [W:0.101 / U:0.148 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site