lkml.org 
[lkml]   [2018]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 20/47] x86/tsc: Fix erroneous TSC rate on Skylake Xeon
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Len Brown <len.brown@intel.com>

    commit b511203093489eb1829cb4de86e8214752205ac6 upstream.

    The INTEL_FAM6_SKYLAKE_X hardcoded crystal_khz value of 25MHZ is
    problematic:

    - SKX workstations (with same model # as server variants) use a 24 MHz
    crystal. This results in a -4.0% time drift rate on SKX workstations.

    - SKX servers subject the crystal to an EMI reduction circuit that reduces its
    actual frequency by (approximately) -0.25%. This results in -1 second per
    10 minute time drift as compared to network time.

    This issue can also trigger a timer and power problem, on configurations
    that use the LAPIC timer (versus the TSC deadline timer). Clock ticks
    scheduled with the LAPIC timer arrive a few usec before the time they are
    expected (according to the slow TSC). This causes Linux to poll-idle, when
    it should be in an idle power saving state. The idle and clock code do not
    graciously recover from this error, sometimes resulting in significant
    polling and measurable power impact.

    Stop using native_calibrate_tsc() for INTEL_FAM6_SKYLAKE_X.
    native_calibrate_tsc() will return 0, boot will run with tsc_khz = cpu_khz,
    and the TSC refined calibration will update tsc_khz to correct for the
    difference.

    [ tglx: Sanitized change log ]

    Fixes: 6baf3d61821f ("x86/tsc: Add additional Intel CPU models to the crystal quirk list")
    Signed-off-by: Len Brown <len.brown@intel.com>
    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    Cc: peterz@infradead.org
    Cc: Prarit Bhargava <prarit@redhat.com>
    Link: https://lkml.kernel.org/r/ff6dcea166e8ff8f2f6a03c17beab2cb436aa779.1513920414.git.len.brown@intel.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    arch/x86/kernel/tsc.c | 1 -
    1 file changed, 1 deletion(-)

    --- a/arch/x86/kernel/tsc.c
    +++ b/arch/x86/kernel/tsc.c
    @@ -693,7 +693,6 @@ unsigned long native_calibrate_tsc(void)
    case INTEL_FAM6_KABYLAKE_DESKTOP:
    crystal_khz = 24000; /* 24.0 MHz */
    break;
    - case INTEL_FAM6_SKYLAKE_X:
    case INTEL_FAM6_ATOM_DENVERTON:
    crystal_khz = 25000; /* 25.0 MHz */
    break;

    \
     
     \ /
      Last update: 2018-01-22 09:51    [W:4.149 / U:0.452 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site