lkml.org 
[lkml]   [2018]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v6 3/4] vfs: Add timestamp_truncate() api
On Sun, Jan 21, 2018 at 6:04 PM, Deepa Dinamani <deepa.kernel@gmail.com> wrote:
> + t.tv_nsec -= t.tv_nsec % gran;

This doesn't actuall ywork if tv_nsec is negative.

Which may not be an issue in most cases, but did somebody check
utimensat() or whatever?

> + WARN(1, "illegal file time granularity: %u", gran);

.. small nit: we generally should use 'invalid' rather than 'illegal'.

No cops will hunt you down for things like this.

Linus

\
 
 \ /
  Last update: 2018-01-22 21:26    [W:0.035 / U:1.128 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site