lkml.org 
[lkml]   [2018]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] staging: lustre: Fix comment style
On Fri, Jan 19, 2018 at 05:53:59PM -0800, Joe Perches wrote:
> On Thu, 2018-01-18 at 16:51 +0100, Fabian Huegel wrote:
> > Most multi-line comments started on the first line, but the preferred
> > linux kernel style is to start multi-line comments on the second line.
> > Some comments became less readable after the change, so we changed them
> > to single-line comments.
> []
> > diff --git a/drivers/staging/lustre/lustre/include/obd_class.h b/drivers/staging/lustre/lustre/include/obd_class.h
> >
> > @@ -182,7 +179,8 @@ struct config_llog_data {
> > struct obd_export *cld_mgcexp;
> > struct mutex cld_lock;
> > int cld_type;
> > - unsigned int cld_stopping:1, /* we were told to stop
> > + unsigned int cld_stopping:1, /*
> > + * we were told to stop
> > * watching
> > */
> > cld_lostlock:1; /* lock not requeued */
>
> probably better for both of these to be bool
> instead of bitfield.

That's a change best left for a separate patch :)

thanks,

greg k-h

\
 
 \ /
  Last update: 2018-01-22 11:38    [W:0.035 / U:0.180 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site