lkml.org 
[lkml]   [2018]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 0/2] printk: Console owner and waiter logic cleanup
On (01/22/18 17:56), Sergey Senozhatsky wrote:
[..]
> Assume the following,

But more importantly we are missing another huge thing - console_unlock().

Suppose:

console_lock();
<< preemption >>
printk
printk
..
printk
console_unlock()
for (;;) {
call_console_drivers()
dump_stack
queue IRQ work

IRQ work >>
flush_printk_safe
printk_deferred()
...
printk_deferred()
<< iret
}

This should explode: sleepable console_unlock() may reschedule,
printk_safe flush bypasses recursion checks.

-ss

\
 
 \ /
  Last update: 2018-01-22 11:29    [W:0.088 / U:2.408 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site