lkml.org 
[lkml]   [2018]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] iio/adc: depend on SYSFS instead of selecting it
On Sun, 14 Jan 2018 21:11:05 -0800
Randy Dunlap <rdunlap@infradead.org> wrote:

> From: Randy Dunlap <rdunlap@infradead.org>
>
> Drivers should not 'select' a subsystem. Instead they should depend
> on it. If the subsystem is disabled, the user probably did that for
> a purpose and one driver shouldn't be changing that.
>
> This also makes all IIO drivers consistent w.r.t depending on SYSFS
> instead of selecting it.
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Jonathan Cameron <jic23@kernel.org>
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.

Whilst thinking on the autobuilders, I'd love to relax the constraint
that this depends on the at91 subarch and at least allow build testing.
Will greatly improve our test coverage.

Maxime, I ran a quick test and it's fine on x86_64 anyway. Do you know of
any reason we will get build problems on other platforms?

Thanks,

Jonathan

> Cc: linux-iio@vger.kernel.org
> ---
> drivers/iio/adc/Kconfig | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> --- lnx-415-rc8.orig/drivers/iio/adc/Kconfig
> +++ lnx-415-rc8/drivers/iio/adc/Kconfig
> @@ -144,10 +144,9 @@ config ASPEED_ADC
> config AT91_ADC
> tristate "Atmel AT91 ADC"
> depends on ARCH_AT91
> - depends on INPUT
> + depends on INPUT && SYSFS
> select IIO_BUFFER
> select IIO_TRIGGERED_BUFFER
> - select SYSFS
> help
> Say yes here to build support for Atmel AT91 ADC.
>

\
 
 \ /
  Last update: 2018-01-21 13:35    [W:0.044 / U:9.000 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site