lkml.org 
[lkml]   [2018]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V1] tty: fix data race between tty_init_dev and flush of buf
On Wed, 17 Jan 2018 18:54:19 +0530
Gaurav Kohli <gkohli@codeaurora.org> wrote:

> There can be a race, if receive_buf call comes before
> tty initialization completes in n_tty_open and tty->disc_data
> may be NULL.
>
> CPU0 CPU1
> ---- ----
> 000|n_tty_receive_buf_common() n_tty_open()
> -001|n_tty_receive_buf2() tty_ldisc_open.isra.3()
> -002|tty_ldisc_receive_buf(inline) tty_ldisc_setup()
>
> Using ldisc semaphore lock in tty_init_dev till disc_data
> initializes completely.
>
> Signed-off-by: Gaurav Kohli <gkohli@codeaurora.org>

Reviewed-by: Alan Cox <alan@linux.intel.com>

Alan

\
 
 \ /
  Last update: 2018-01-20 19:50    [W:0.030 / U:0.800 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site