lkml.org 
[lkml]   [2018]   [Jan]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v1 00/15] ASoC: fsl_ssi: Clean up - program flow level
    On Tue, Dec 19, 2017 at 9:00 AM, Nicolin Chen <nicoleotsuka@gmail.com> wrote:
    >
    > ==Background==
    > The fsl_ssi driver was designed for PPC originally and then it has
    > been updated to support different modes for i.MX Series, including
    > SDMA, I2S Master mode, AC97 and older i.MXs with FIQ, by different
    > contributors for different use cases in different coding styles.
    >
    > Additionally, in order to fix/work-around hardware bugs and design
    > flaws, the driver made a lot of compromise so now its program flow
    > looks very complicated and it's getting hard to maintain or update.
    >
    > So I am going to clean up the driver on both coding style level and
    > program flow level.
    >
    > ==Introduction==
    > This series of patches is the second set to clean up fsl_ssi driver
    > in the program flow level. Any patch here may impact a fundamental
    > test case like playback or record.
    >
    > ==Verification==
    > This series of patches require fully tested. I have done such tests
    > on i.MX6SoloX with WM8962 using imx_v6_v7_defconfig as:
    > - Playback via I2S Master and Slave mode
    > - Record via I2S Master and Slave mode
    > - Simultaneous playback and record via I2S Master and Slave mode
    > - Background playback with foreground record (starting at different
    > time) via I2S Master and Slave mode
    > - Background record with foreground playback (starting at different
    > time) via I2S Master and Slave mode
    > * All tests above by hacking offline_config to true in imx51.
    >
    > Example of uncovered tests: TDM, AC97, PowerPC and FIQ.
    >
    > Nicolin Chen (15):
    > ASoC: fsl_ssi: Clean up set_dai_tdm_slot()
    > ASoC: fsl_ssi: Maintain a mask of active streams
    > ASoC: fsl_ssi: Rename fsl_ssi_disable_val macro
    > ASoC: fsl_ssi: Clear FIFO directly in fsl_ssi_config()
    > ASoC: fsl_ssi: Clean up helper functions of trigger()
    > ASoC: fsl_ssi: Add DAIFMT define for AC97
    > ASoC: fsl_ssi: Clean up fsl_ssi_setup_regvals()
    > ASoC: fsl_ssi: Set xFEN0 and xFEN1 together
    > ASoC: fsl_ssi: Use snd_soc_init_dma_data instead
    > ASoC: fsl_ssi: Move one-time configurations to dai_probe()
    > ASoC: fsl_ssi: Setup AC97 in dai_probe()
    > ASoC: fsl_ssi: Clean up _fsl_ssi_set_dai_fmt()
    > ASoC: fsl_ssi: Remove cpu_dai_drv from fsl_ssi structure
    > ASoC: fsl_ssi: Move DT related code to a separate probe()
    > ASoC: fsl_ssi: Use ssi->streams instead of reading register
    >
    > sound/soc/fsl/fsl_ssi.c | 710 ++++++++++++++++++++++++------------------------
    > 1 file changed, 348 insertions(+), 362 deletions(-)
    >
    > --
    > 2.7.4
    >

    tested this patch set on MX6 SSI against broonie for-next (4.15-rc5),
    no problems.
    Do I send a separate Tested-by for each patch, or just the 00/15 one?



    Tested-by: Caleb Crome <caleb@crome.org>

    \
     
     \ /
      Last update: 2018-01-03 00:29    [W:2.265 / U:0.192 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site