lkml.org 
[lkml]   [2018]   [Jan]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 0/3] tpm: fix PS/2 devices not working on Braswell systems due CLKRUN enabled
On Mon, Dec 25, 2017 at 03:22:48AM +0100, Javier Martinez Canillas wrote:
> Hello,
>
> Commit 5e572cab92f0 ("tpm: Enable CLKRUN protocol for Braswell systems")
> added logic in the TPM TIS driver to disable the Low Pin Count CLKRUN
> signal during TPM transactions.
>
> Unfortunately this breaks other devices that are attached to the LPC bus
> like for example PS/2 mouse and keyboards.
>
> The bug was reported to the Fedora kernel [0] and the kernel bugzilla [1].
> This issue and the propossed solution were discussed in this [2] thread,
> and the reporter (Jame Ettle) confirmed that his system works again after
> the fix in this series.
>
> The patches are based on top or Jarkko Sakkinen's linux-tpmdd [3] tree.
>
> Changes since v1:
> - Add collected tags
> - Drop patch that fixed a bug in the error path since was already fixed.
>
> [0]: https://bugzilla.redhat.com/show_bug.cgi?id=1498987
> [1]: https://bugzilla.kernel.org/show_bug.cgi?id=197287
> [2]: https://patchwork.kernel.org/patch/10119417/
> [3]: git.infradead.org/users/jjs/linux-tpmdd.git
>
> Best regards,
> Javier
>
>
> Javier Martinez Canillas (3):
> tpm: delete the TPM_TIS_CLK_ENABLE flag
> tpm: follow coding style for variable declaration in
> tpm_tis_core_init()
> tpm: only attempt to disable the LPC CLKRUN if is already enabled
>
> drivers/char/tpm/tpm_tis.c | 15 ---------------
> drivers/char/tpm/tpm_tis_core.c | 17 +++++++++++++----
> drivers/char/tpm/tpm_tis_core.h | 1 -
> 3 files changed, 13 insertions(+), 20 deletions(-)
>
> --
> 2.14.3
>

Thanks, these are now applied.

/Jarkko

\
 
 \ /
  Last update: 2018-01-02 15:41    [W:0.037 / U:10.152 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site