Messages in this thread | | | Subject | Re: [PATCH v3] drm/ttm: check the return value of kzalloc | From | Christian König <> | Date | Tue, 2 Jan 2018 15:33:51 +0100 |
| |
Am 02.01.2018 um 14:24 schrieb Xiongwei Song: > In the function ttm_page_alloc_init, kzalloc call is made for variable > _manager, we need to check its return value, it may return NULL. > > Signed-off-by: Xiongwei Song <sxwjean@gmail.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Going to pick that up for the next release.
Thanks, Christian.
> --- > v2->v3: delete goto expression > v1->v2: delete kfree _manager > --- > drivers/gpu/drm/ttm/ttm_page_alloc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/ttm/ttm_page_alloc.c b/drivers/gpu/drm/ttm/ttm_page_alloc.c > index b5ba6441489f..5d252fb27a82 100644 > --- a/drivers/gpu/drm/ttm/ttm_page_alloc.c > +++ b/drivers/gpu/drm/ttm/ttm_page_alloc.c > @@ -1007,6 +1007,8 @@ int ttm_page_alloc_init(struct ttm_mem_global *glob, unsigned max_pages) > pr_info("Initializing pool allocator\n"); > > _manager = kzalloc(sizeof(*_manager), GFP_KERNEL); > + if (!_manager) > + return -ENOMEM; > > ttm_page_pool_init_locked(&_manager->wc_pool, GFP_HIGHUSER, "wc", 0); >
| |