lkml.org 
[lkml]   [2018]   [Jan]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] MIPS: Remove a warning when PHYS_OFFSET is 0x0
On Tue, Dec 26, 2017 at 12:37:14PM +0100, Mathieu Malaterre wrote:
> Rewrite the comparison in `else if` statement, case where `min_low_pfn >
> ARCH_PFN_OFFSET` has already been checked in the first `if` statement:
>
> if (min_low_pfn > ARCH_PFN_OFFSET) {
>
> Fix non-fatal warning:
>
> arch/mips/kernel/setup.c: In function ‘bootmem_init’:
> arch/mips/kernel/setup.c:461:25: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
> } else if (min_low_pfn < ARCH_PFN_OFFSET) {
> ^

What compiler version is that with out of interest? It isn't exactly new
code.

>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>

Reviewed-by: James Hogan <jhogan@kernel.org>

Cheers
James

> ---
> arch/mips/kernel/setup.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c
> index f19d61224c71..073695ccc1aa 100644
> --- a/arch/mips/kernel/setup.c
> +++ b/arch/mips/kernel/setup.c
> @@ -458,7 +458,7 @@ static void __init bootmem_init(void)
> pr_info("Wasting %lu bytes for tracking %lu unused pages\n",
> (min_low_pfn - ARCH_PFN_OFFSET) * sizeof(struct page),
> min_low_pfn - ARCH_PFN_OFFSET);
> - } else if (min_low_pfn < ARCH_PFN_OFFSET) {
> + } else if (ARCH_PFN_OFFSET - min_low_pfn > 0UL) {
> pr_info("%lu free pages won't be used\n",
> ARCH_PFN_OFFSET - min_low_pfn);
> }
> --
> 2.11.0
>
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2018-01-02 10:32    [W:0.062 / U:0.416 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site