Messages in this thread | | | From | "Shaikh, Azhar" <> | Subject | RE: [PATCH v8 1/2] tpm_tis: Move ilb_base_addr to tpm_tis_data | Date | Tue, 2 Jan 2018 05:01:54 +0000 |
| |
>-----Original Message----- >From: Jason Gunthorpe [mailto:jgg@ziepe.ca] >Sent: Monday, January 1, 2018 8:41 PM >To: Shaikh, Azhar <azhar.shaikh@intel.com> >Cc: jarkko.sakkinen@linux.intel.com; peterhuewe@gmx.de; linux-security- >module@vger.kernel.org; linux-integrity@vger.kernel.org; linux- >kernel@vger.kernel.org >Subject: Re: [PATCH v8 1/2] tpm_tis: Move ilb_base_addr to tpm_tis_data > >On Mon, Jan 01, 2018 at 08:05:43PM -0800, Azhar Shaikh wrote: > >> - return tpm_chip_register(chip); >> + rc = tpm_chip_register(chip); >> + if (rc && is_bsw()) >> + iounmap(priv->ilb_base_addr); >> + >> + return rc; >> out_err: >> tpm_tis_remove(chip); >> + if (is_bsw()) >> + iounmap(priv->ilb_base_addr); >> + >> return rc; >> } > >I thought you were resending this to fix the above, why is is it still wonky? >
Oh! I fixed it in the second patch ("tpm: Keep CLKRUN enabled throughout the duration of transmit_cmd()"). Should have fixed in this patch instead. My bad, didn't see it was introduced in this patch. I thought it was part of second patch. Will fix this.
>Jason
| |