Messages in this thread | | | Subject | Re: [PATCH v6 6/9] media: i2c: ov772x: Remove soc_camera dependencies | From | Hans Verkuil <> | Date | Fri, 19 Jan 2018 11:47:33 +0100 |
| |
On 01/19/18 11:24, Hans Verkuil wrote: > On 01/16/18 22:44, Jacopo Mondi wrote: >> Remove soc_camera framework dependencies from ov772x sensor driver. >> - Handle clock and gpios >> - Register async subdevice >> - Remove soc_camera specific g/s_mbus_config operations >> - Change image format colorspace from JPEG to SRGB as the two use the >> same colorspace information but JPEG makes assumptions on color >> components quantization that do not apply to the sensor >> - Remove sizes crop from get_selection as driver can't scale >> - Add kernel doc to driver interface header file >> - Adjust build system >> >> This commit does not remove the original soc_camera based driver as long >> as other platforms depends on soc_camera-based CEU driver. >> >> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> >> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Un-acked.
I just noticed that this sensor driver has no enum_frame_interval and g/s_parm support. How would a driver ever know the frame rate of the sensor without that?
This looks like a bug to me.
Regards,
Hans
| |