Messages in this thread | | | Date | Thu, 18 Jan 2018 19:31:34 -0500 | From | Steven Rostedt <> | Subject | Re: [PATCH-next] init/main.c: make local symbol static |
| |
On Thu, 18 Jan 2018 18:33:27 -0500 Christopher Díaz Riveros <chrisadr@gentoo.org> wrote:
> > > What about the other user(s) of envp_init? > > > > It looks like it's referenced in init/do_mounts_initrd.c. Rather > > than making it static, it should be declared in .h file. > > > > Ok, I'll try to figure it out, akpm accepted the patch in mm-next but > was dropped because of testing failures. I'm still very new to all of > this process.
Yeah, because do_mounts_initrd.c didn't compile. If you do add it to a header, use a header local in the init directory. Do not expose envp_init to the entire kernel.
-- Steve
| |